Fix/slider issues#216
Open
meganrm wants to merge 3 commits into
Open
Conversation
meganrm
requested review from
ShrimpCryptid,
Copilot and
tyler-foster
and removed request for
a team
Comment on lines
84
to
88
| <InputNumber | ||
| aria-labelledby="ki-question" | ||
| value={selectedAnswer || ""} | ||
| value={selectedAnswer ?? ""} | ||
| onChange={handleAnswerSelection} | ||
| placeholder="Type value..." |
Comment on lines
105
to
109
| <InputNumber | ||
| aria-labelledby="kd question" | ||
| value={selectedAnswer || ""} | ||
| value={selectedAnswer ?? ""} | ||
| onChange={handleAnswerSelection} | ||
| placeholder="Type value..." |
| const isFormMaximized = lastOpened === id; | ||
| const minimizedTitle = `Q:${id}`; | ||
| const isFormMaximized = lastOpened === formID; | ||
| const minimizedTitle = `Q:${formID}`; |
Contributor
There was a problem hiding this comment.
I do like the rename, but I don't think the variable name formId is descriptive enough for its use case-- it's used as both a unique identifier and as a minimized title, but the name only really implies the first. We talked about making these two different props in #214, would you still want to make that change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: small
closes #214
and there was a small bug were a slider was double labeling the zero value.
Solution
changed the prop name to formID instead of just id
don't add a label if the value is zero
Type of change
Please delete options that are not relevant.
Screenshots (optional):
before:
