cap the step count#215
Open
meganrm wants to merge 1 commit into
Open
Conversation
meganrm
requested review from
Copilot,
frasercl and
toloudis
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Caps the number of steps rendered in the live concentration bar so that each step (plus its 2px gap) has at least 4px of width, preventing visual issues on page 16 where high maxConcentration values caused the bar to render incorrectly.
Changes:
- Compute
maxStepsfrom the availablewidth(at least 4px per step). - Use
Math.min(maxConcentration, Math.max(1, maxSteps))to ensure at least 1 step and never exceed the available width.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShrimpCryptid
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: small
closes #210
Solution
capped the step size of the bar with @claude
Type of change
Please delete options that are not relevant.
Steps to Verify:
Screenshots (optional):
before
