Feature/navigation #202
Feature/navigation #202
Conversation
meganrm
requested review from
ShrimpCryptid and
interim17
and removed request for
a team
| let toReturn = -1; | ||
| map(moduleNames, (name, index) => { | ||
| if (name === title) { | ||
| toReturn = Number(index); |
There was a problem hiding this comment.
Is index not a number?
There was a problem hiding this comment.
it is, typescript didn't believe it, I typed index instead
There was a problem hiding this comment.
it's actually not on further inspection
| <Progress | ||
| className={styles.progressBar} | ||
| size={["100%", 4]} | ||
| percent={getModulePercent( | ||
| isActiveModule, | ||
| moduleIndex | ||
| )} | ||
| showInfo={false} | ||
| /> |
There was a problem hiding this comment.
Is Progress tab focusable + clickable?
Co-authored-by: Peyton Lee <peytonalee@gmail.com>
…nding-sim-edu into feature/navigation
There was a problem hiding this comment.
Pull Request Overview
This PR adds clickable navigation functionality to the module progress bar, allowing users to switch between modules with a confirmation dialog to prevent accidental navigation.
Key changes:
- Added tracking of completed modules using a Set stored in context
- Implemented click handlers with confirmation popups for module navigation
- Refactored module completion logic to mark modules as complete when quiz questions are answered correctly
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/simulation/context.tsx | Adds completedModules state and addCompletedModule handler to context |
| src/simulation/LiveSimulationData.ts | Refactors kds constant to static class property ESTIMATED_SOLUTIONS |
| src/components/quiz-questions/KdQuestion.tsx | Marks module as completed when quiz answer is correct |
| src/components/page-indicator.module.css | Adds hover and click target styles for interactive progress indicators |
| src/components/PageIndicator.tsx | Implements Popconfirm dialogs and click handlers for module navigation |
| src/App.tsx | Initializes completed modules state and clears analysis state on module change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| onConfirm={() => { | ||
| setModule(moduleIndex); | ||
| }} | ||
| onCancel={() => {}} |
There was a problem hiding this comment.
Empty arrow function can be omitted. The onCancel prop is optional and doesn't need to be explicitly set to an empty function if no action is required.
| onCancel={() => {}} |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ShrimpCryptid
left a comment
ShrimpCryptid
left a comment
There was a problem hiding this comment.
Left some comments, looks good!
…nding-sim-edu into feature/navigation
Problem
Estimated review size: small
the navigation bar is supposed to be clickable
Solution
made it clickable with a pop confirm
Type of change
Please delete options that are not relevant.
Steps to Verify:
Screenshots (optional):