Feature/second module #175
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrm
commented
Feb 26, 2025
| @@ -1,5 +1,5 @@ | |||
| import { System, Circle, Response } from "detect-collisions"; | |||
Contributor
Author
There was a problem hiding this comment.
still to do:
- fix _isMixed check
- get product color in
meganrm
commented
Feb 26, 2025
Comment on lines
+88
to
+94
| const [viewportWidth, setViewportWidth] = useState( | ||
| DEFAULT_VIEWPORT_SIZE.width | ||
| ); | ||
| const [viewportHeight, setViewportHeight] = useState( | ||
| DEFAULT_VIEWPORT_SIZE.height | ||
| ); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
- this can be a stand alone fix
meganrm
commented
Feb 28, 2025
Comment on lines
+316
to
+319
| (page) => | ||
| page === 1 && | ||
| currentModule === 1 && | ||
| currentProductConcentrationArray.length > 1, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: small/medium/large
What is the problem this work solves, including
Link to story or ticket
Solution
What I/we did to solve this problem
with @pairperson1
Type of change
Please delete options that are not relevant.
Change summary:
Steps to Verify:
Screenshots (optional):
Show-n-tell images/animations here
Keyfiles (delete if not relevant):
Thanks for contributing!