improvement(ui): improved skills UI, validation, and permissions#3156
Merged
waleedlatif1 merged 4 commits intostagingfrom Feb 6, 2026
Merged
improvement(ui): improved skills UI, validation, and permissions#3156waleedlatif1 merged 4 commits intostagingfrom
waleedlatif1 merged 4 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR enhances the skills feature with improved UI, validation, and permission handling. The main changes include:
The changes follow established patterns for validation, permissions, and data hydration. Minor style improvements suggested for type safety and theme consistency. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant SkillModal
participant SkillInput
participant useEditorSubblockLayout
participant WorkflowBlock
participant PermissionConfig
participant SkillsAPI
Note over User,SkillsAPI: Skill Creation/Edit Flow
User->>SkillModal: Opens modal to create/edit skill
SkillModal->>SkillModal: Validates name (kebab-case, max 64 chars)
SkillModal->>SkillModal: Validates description (required)
SkillModal->>SkillModal: Validates content (required)
alt Validation Fails
SkillModal->>User: Shows field-specific error messages
else Validation Succeeds
SkillModal->>SkillsAPI: createSkill or updateSkill mutation
SkillsAPI-->>SkillModal: Success/Error response
SkillModal->>User: Closes modal or shows general error
end
Note over User,SkillsAPI: Permission Check Flow
User->>useEditorSubblockLayout: Opens editor panel
useEditorSubblockLayout->>PermissionConfig: Check disableSkills flag
alt Skills Disabled
useEditorSubblockLayout->>User: Hides skill-input subblock
else Skills Enabled
useEditorSubblockLayout->>SkillInput: Renders skill-input component
end
Note over User,SkillsAPI: Skill Selection & Display Flow
User->>SkillInput: Selects skill from dropdown
SkillInput->>SkillsAPI: Fetch workspace skills
SkillsAPI-->>SkillInput: Returns skill list
SkillInput->>SkillInput: Stores {skillId, name} in value
SkillInput->>User: Displays skill card with name and icon
Note over User,SkillsAPI: Skill Name Hydration Flow
User->>WorkflowBlock: Views block in workflow canvas
WorkflowBlock->>SkillsAPI: Fetch workspace skills
SkillsAPI-->>WorkflowBlock: Returns fresh skill data
WorkflowBlock->>WorkflowBlock: Resolves skill names with priority:<br/>1. Fresh data from API<br/>2. Stored name (fallback)<br/>3. skillId (last resort)
WorkflowBlock->>User: Displays hydrated skill names
|
.../sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx
Outdated
Show resolved
Hide resolved
.../sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/workflow-block.tsx
Outdated
Show resolved
Hide resolved
...mponents/panel/components/editor/components/sub-block/components/skill-input/skill-input.tsx
Show resolved
Hide resolved
Collaborator
Author
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
.../w/components/sidebar/components/settings-modal/components/skills/components/skill-modal.tsx
Outdated
Show resolved
Hide resolved
...mponents/panel/components/editor/components/sub-block/components/skill-input/skill-input.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
tested manually
Checklist