fix(popover): fix frozen workspace popover#2832
Merged
waleedlatif1 merged 1 commit intostagingfrom Jan 15, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryFixed frozen workspace popover by removing event handlers that blocked normal close behavior and ensuring both the context menu and workspace dropdown close together.
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant WorkspaceDropdown
participant ContextMenu
participant RadixUI
User->>WorkspaceDropdown: Click to open
WorkspaceDropdown->>RadixUI: Set isWorkspaceMenuOpen=true
User->>WorkspaceDropdown: Right-click workspace item
WorkspaceDropdown->>ContextMenu: Open context menu
ContextMenu->>RadixUI: Set isContextMenuOpen=true
Note over ContextMenu: Previously: onPointerDownOutside/onInteractOutside<br/>prevented RadixUI from closing
User->>RadixUI: Click outside
RadixUI->>ContextMenu: Trigger close (now works!)
ContextMenu->>WorkspaceDropdown: closeContextMenu()
Note over WorkspaceDropdown: New: Also closes workspace dropdown
WorkspaceDropdown->>RadixUI: Set isWorkspaceMenuOpen=false
ContextMenu->>RadixUI: Set isContextMenuOpen=false
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist