feat(combobox): added expression support to combobox#2697
Merged
waleedlatif1 merged 4 commits intostagingfrom Jan 7, 2026
Merged
feat(combobox): added expression support to combobox#2697waleedlatif1 merged 4 commits intostagingfrom
waleedlatif1 merged 4 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR adds expression support to the combobox component, allowing it to accept dynamic expressions like Key changes:
Note: Previous thread comments about infinite loops and expression detection have been acknowledged by the developer. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ComboBox
participant SubBlockStore
participant FetchOptions API
participant SubBlockInputController
User->>ComboBox: Opens combobox
ComboBox->>ComboBox: Check if fetchOptions exists
alt Has fetchOptions
ComboBox->>FetchOptions API: fetchOptions(blockId, subBlockId)
FetchOptions API-->>ComboBox: Return options array
ComboBox->>ComboBox: Set fetchedOptions state
end
ComboBox->>ComboBox: Check stored value
alt Value exists and not in options
ComboBox->>FetchOptions API: fetchOptionById(blockId, subBlockId, value)
FetchOptions API-->>ComboBox: Return hydrated option
ComboBox->>ComboBox: Merge hydrated option into options
end
User->>ComboBox: Selects/types value
alt Value matches option
ComboBox->>SubBlockInputController: onChange(option.id)
else Value is expression (no match)
ComboBox->>SubBlockInputController: onChange(rawValue)
end
SubBlockInputController->>SubBlockStore: Store value
Note over ComboBox,SubBlockStore: Dependency tracking
SubBlockStore-->>ComboBox: dependencyValues change
ComboBox->>ComboBox: Clear fetchedOptions
ComboBox->>FetchOptions API: Re-fetch options
|
...Id]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx
Show resolved
Hide resolved
b01884c to
ebe4a1d
Compare
Collaborator
Author
|
@greptile |
1 similar comment
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@greptile |
...Id]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx
Outdated
Show resolved
Hide resolved
...Id]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx
Show resolved
Hide resolved
Collaborator
Author
|
@greptile |
waleedlatif1
added a commit
that referenced
this pull request
Jan 8, 2026
* feat(combobox): added expression support to combobox * fix chat messages styling in light mode * last sec stuff * ack comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist