improvement(context-menu): disable undo and redo if the stack is empty#2657
Merged
waleedlatif1 merged 1 commit intostagingfrom Jan 1, 2026
Merged
improvement(context-menu): disable undo and redo if the stack is empty#2657waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR disables the Undo and Redo options in the context menu when their respective stacks are empty, preventing users from attempting invalid operations. The implementation correctly reads the undo/redo stack state from the store using the proper key format ( Changes Summary:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ContextMenu as PaneContextMenu
participant WorkflowComponent as WorkflowContent
participant UndoRedoStore as useUndoRedoStore
participant AuthSession as useSession
User->>WorkflowComponent: Right-click canvas to open context menu
WorkflowComponent->>AuthSession: Get current user session
AuthSession-->>WorkflowComponent: Return user ID
WorkflowComponent->>UndoRedoStore: Query stacks[workflowId:userId]
UndoRedoStore-->>WorkflowComponent: Return undo/redo stacks
WorkflowComponent->>WorkflowComponent: Compute canUndo = undo.length > 0
WorkflowComponent->>WorkflowComponent: Compute canRedo = redo.length > 0
WorkflowComponent->>ContextMenu: Render with canUndo, canRedo props
ContextMenu->>ContextMenu: Set Undo disabled = disableEdit || !canUndo
ContextMenu->>ContextMenu: Set Redo disabled = disableEdit || !canRedo
ContextMenu-->>User: Display context menu with disabled state
alt Stack has operations
User->>ContextMenu: Click Undo/Redo
ContextMenu->>WorkflowComponent: Call onUndo/onRedo callback
WorkflowComponent->>UndoRedoStore: Execute undo/redo operation
else Stack is empty
User->>ContextMenu: Try to click Undo/Redo (button is grayed out)
Note over ContextMenu: Button is disabled, no action taken
end
|
waleedlatif1
added a commit
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist