fix(opencode): harden root path and retry errors

Author: Danigm-dev

apps/sim/lib/opencode/service.test.ts

@@ -2,7 +2,7 @@
  * @vitest-environment node
  */
 
-import { describe, expect, it, vi } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockCreateOpenCodeClient } = vi.hoisted(() => ({
   mockCreateOpenCodeClient: vi.fn(),
@@ -39,10 +39,19 @@ vi.mock('@/lib/opencode/client', () => ({
 }))
 
 import {
+  listOpenCodeRepositories,
   promptOpenCodeSession,
   shouldRetryWithFreshOpenCodeSession,
 } from '@/lib/opencode/service'
 
+beforeEach(() => {
+  vi.clearAllMocks()
+})
+
+afterEach(() => {
+  vi.unstubAllEnvs()
+})
+
 describe('shouldRetryWithFreshOpenCodeSession', () => {
   it('returns true for stale-session errors', () => {
     expect(shouldRetryWithFreshOpenCodeSession(new Error('404 session not found'))).toBe(true)
@@ -56,6 +65,36 @@ describe('shouldRetryWithFreshOpenCodeSession', () => {
     expect(shouldRetryWithFreshOpenCodeSession('model not found')).toBe(false)
     expect(shouldRetryWithFreshOpenCodeSession('provider does not exist')).toBe(false)
   })
+
+  it('does not crash for undefined, symbol, or function errors', () => {
+    expect(() => shouldRetryWithFreshOpenCodeSession(undefined)).not.toThrow()
+    expect(() => shouldRetryWithFreshOpenCodeSession(Symbol('session'))).not.toThrow()
+    expect(() => shouldRetryWithFreshOpenCodeSession(() => 'session')).not.toThrow()
+    expect(shouldRetryWithFreshOpenCodeSession(undefined)).toBe(false)
+  })
+})
+
+describe('listOpenCodeRepositories', () => {
+  it('handles OPENCODE_REPOSITORY_ROOT set to / without double slashes', async () => {
+    vi.stubEnv('OPENCODE_REPOSITORY_ROOT', '/')
+
+    mockCreateOpenCodeClient.mockReturnValue({
+      project: {
+        list: vi.fn().mockResolvedValue({
+          data: [{ id: 'project-1', worktree: '/repo-a' }],
+        }),
+      },
+    })
+
+    await expect(listOpenCodeRepositories()).resolves.toEqual([
+      {
+        id: 'repo-a',
+        label: 'repo-a',
+        directory: '/repo-a',
+        projectId: 'project-1',
+      },
+    ])
+  })
 })
 
 describe('promptOpenCodeSession', () => {

apps/sim/lib/opencode/service.ts

@@ -85,7 +85,7 @@ function getOpenCodeRepositoryRoot(): string {
   }
 
   if (configuredRoot === '/') {
-    return configuredRoot
+    return ''
   }
 
   return configuredRoot.replace(/\/+$/, '')
@@ -516,12 +516,7 @@ export function buildOpenCodeSessionTitle(repository: string, userKey: string):
 }
 
 export function shouldRetryWithFreshOpenCodeSession(error: unknown): boolean {
-  const message =
-    error instanceof Error
-      ? error.message
-      : typeof error === 'string'
-        ? error
-        : JSON.stringify(error)
+  const message = getOpenCodeRetryErrorMessage(error)
 
   const normalized = message.toLowerCase()
   const staleSessionPatterns = [
@@ -540,6 +535,25 @@ export function shouldRetryWithFreshOpenCodeSession(error: unknown): boolean {
   return normalized.includes('404') && normalized.includes('session')
 }
 
+function getOpenCodeRetryErrorMessage(error: unknown): string {
+  if (error instanceof Error) {
+    return error.message
+  }
+
+  if (typeof error === 'string') {
+    return error
+  }
+
+  try {
+    const serialized = JSON.stringify(error)
+    if (typeof serialized === 'string') {
+      return serialized
+    }
+  } catch {}
+
+  return String(error ?? '')
+}
+
 export async function logOpenCodeFailure(
   message: string,
   error: unknown