fix(opencode): clean up low severity review notes

Author: Danigm-dev

apps/sim/app/api/tools/opencode/prompt/route.ts

@@ -14,6 +14,7 @@ import {
   shouldRetryWithFreshOpenCodeSession,
   storeOpenCodeSession,
 } from '@/lib/opencode/service'
+import { coerceOpenCodeBoolean } from '@/lib/opencode/utils'
 
 const logger = createLogger('OpenCodePromptToolAPI')
 
@@ -44,18 +45,6 @@ const OpenCodePromptSchema = z.object({
 export const dynamic = 'force-dynamic'
 export const runtime = 'nodejs'
 
-function coerceBoolean(value: boolean | string | undefined): boolean {
-  if (typeof value === 'boolean') {
-    return value
-  }
-
-  if (typeof value === 'string') {
-    return value.toLowerCase() === 'true'
-  }
-
-  return false
-}
-
 function getSessionOwnerKey(params: z.infer<typeof OpenCodePromptSchema>): string {
   if (params._context?.userId) {
     return `user:${params._context.userId}`
@@ -145,7 +134,7 @@ export async function POST(request: NextRequest) {
     const modelId = body.modelId.trim()
     const sessionOwnerKey = getSessionOwnerKey(body)
     const memoryKey = buildOpenCodeSessionMemoryKey(workflowId, sessionOwnerKey)
-    const newThread = coerceBoolean(body.newThread)
+    const newThread = coerceOpenCodeBoolean(body.newThread)
     const storedThread = newThread ? null : await getStoredOpenCodeSession(workspaceId, memoryKey)
     let threadId =
       storedThread && storedThread.repository === repositoryId

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx

@@ -136,7 +136,6 @@ export const ComboBox = memo(function ComboBox({
       !fetchOptions ||
       isPreview ||
       disabled ||
-      isLoadingOptions ||
       (!force && hasAttemptedOptionsFetch) ||
       isOptionsFetchInFlightRef.current
     ) {
@@ -164,7 +163,6 @@ export const ComboBox = memo(function ComboBox({
     subBlockId,
     isPreview,
     disabled,
-    isLoadingOptions,
     hasAttemptedOptionsFetch,
   ])
 

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx

@@ -161,7 +161,6 @@ export const Dropdown = memo(function Dropdown({
       !fetchOptions ||
       isPreview ||
       disabled ||
-      isLoadingOptions ||
       (!force && hasAttemptedOptionsFetch) ||
       isOptionsFetchInFlightRef.current
     ) {
@@ -189,7 +188,6 @@ export const Dropdown = memo(function Dropdown({
     subBlockId,
     isPreview,
     disabled,
-    isLoadingOptions,
     hasAttemptedOptionsFetch,
   ])
 

apps/sim/blocks/blocks/opencode.ts

@@ -1,22 +1,11 @@
 import type { BlockConfig } from '@/blocks/types'
 import { OpenCodeIcon } from '@/components/icons'
 import { getEnv, isTruthy } from '@/lib/core/config/env'
+import { coerceOpenCodeBoolean } from '@/lib/opencode/utils'
 import type { OpenCodePromptResponse } from '@/tools/opencode/types'
 
 const isOpenCodeEnabled = isTruthy(getEnv('NEXT_PUBLIC_OPENCODE_ENABLED'))
 
-function coerceBoolean(value: unknown): boolean {
-  if (typeof value === 'boolean') {
-    return value
-  }
-
-  if (typeof value === 'string') {
-    return value.toLowerCase() === 'true'
-  }
-
-  return false
-}
-
 function getOptionalString(value: unknown): string | undefined {
   if (typeof value !== 'string') {
     return undefined
@@ -230,7 +219,7 @@ export const OpenCodeBlock: BlockConfig<OpenCodePromptResponse> = {
         modelId: params.modelId,
         ...(getOptionalString(params.agent) ? { agent: getOptionalString(params.agent) } : {}),
         prompt: params.prompt,
-        newThread: coerceBoolean(params.newThread),
+        newThread: coerceOpenCodeBoolean(params.newThread),
       }),
     },
   },

apps/sim/lib/opencode/utils.test.ts

@@ -0,0 +1,18 @@
+/**
+ * @vitest-environment node
+ */
+
+import { describe, expect, it } from 'vitest'
+import { coerceOpenCodeBoolean } from '@/lib/opencode/utils'
+
+describe('coerceOpenCodeBoolean', () => {
+  it('coerces booleans and string booleans consistently', () => {
+    expect(coerceOpenCodeBoolean(true)).toBe(true)
+    expect(coerceOpenCodeBoolean(false)).toBe(false)
+    expect(coerceOpenCodeBoolean('true')).toBe(true)
+    expect(coerceOpenCodeBoolean('TRUE')).toBe(true)
+    expect(coerceOpenCodeBoolean('false')).toBe(false)
+    expect(coerceOpenCodeBoolean(undefined)).toBe(false)
+    expect(coerceOpenCodeBoolean(null)).toBe(false)
+  })
+})

apps/sim/lib/opencode/utils.ts

@@ -0,0 +1,11 @@
+export function coerceOpenCodeBoolean(value: unknown): boolean {
+  if (typeof value === 'boolean') {
+    return value
+  }
+
+  if (typeof value === 'string') {
+    return value.toLowerCase() === 'true'
+  }
+
+  return false
+}