Conversation
6a63086 to
8a58211
Compare
8a58211 to
91a8fe0
Compare
4cbfffe to
4493bf7
Compare
4493bf7 to
5315d40
Compare
5315d40 to
27713a3
Compare
There was a problem hiding this comment.
Pull request overview
Adds new integration coverage for two key Vela capabilities—branch cloning and restoring a branch from a backup—by creating branches through the public API and waiting until they reach ACTIVE_HEALTHY.
Changes:
- Added
tests/test_backup_and_clone.pyto exercise branch clone and restore-from-backup flows. - Reduced the default
BRANCH_TIMEOUT_SECused bywait_for_status. - Registered the new test file in pytest
testpaths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
tests/test_backup_and_clone.py |
New integration tests for cloning a branch and restoring a branch from a manual backup. |
tests/conftest.py |
Changes the default branch status polling timeout used across integration tests. |
pyproject.toml |
Adds the new test module to pytest’s configured testpaths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
27713a3 to
d9dccad
Compare
d9dccad to
8372bde
Compare
8372bde to
9c78bbd
Compare
mxsrc
left a comment
There was a problem hiding this comment.
I like this, but I feel we need to establish a clearer structure. With this change test_branches.py does not do what says anymore. Can we create a hierarchy? Like tests/branches/test_{basic,clone_restore}.py. Also, it'd be great to have a fixture for branch creation akin to the organization/project fixtures.
|
restructured the tests to |
d77f669 to
4d0b278
Compare
|
I see the tests are still running, so I converted this PR to a draft. Can you reopen it and give me a ping when it's ready for review? From a quick glance things look fine overall :) |
mxsrc
left a comment
There was a problem hiding this comment.
Looks largely good, can we remove the comment sections though? I'm really not a fan of those, they tend to be forgotten and at least for me don't add much value. If they help you we can also keep them.
36cecee to
d1b016c
Compare
Branch clone and restore a branch from a backup are one of the signature feature of vela.
Adding tests for this to make sure that they work as expected as we make more and changes
The changes in the PR, create a cloned branch or creates a branch from a backup and makes sure that its active healthy.
next
In the PR the plan is to add tests to make sure that data is persisted from source clone to target clone.