Address uncovered simplyblock API errors#580
Merged
boddumanohar merged 10 commits intomainfrom Feb 7, 2026
Merged
Conversation
We only every use the API for interaction below the pool level. The type name is adapted to reflect that.
This will never change so we can do this once to assemble the base-URL.
The recent changes in the API propagate all errors as VelaSimplyblockAPIError, this simplifies the call-sites.
boddumanohar
reviewed
Feb 6, 2026
src/deployment/simplyblock_api.py
Outdated
| cluster_secret=cluster_secret, | ||
| client=client, | ||
| ) | ||
| api = SimplyblockPoolApi(*(await load_simplyblock_credentials()), "testing1") |
Member
There was a problem hiding this comment.
might be better to put the simplyblock pool name in a constant variable in rather than hardcode.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I kept it here because its the only occurence. Ideally we wouldnt even use this but request it from CSI, I couldnt figure out quickly where it resides though. Let me try that again.
Member
There was a problem hiding this comment.
It would be much better if you could get it from CSI. It's available here.
kubectl -n simplyblock-csi get sc simplyblock-csi-sc -ojson | jq -r .parameters.pool_name
Collaborator
Author
There was a problem hiding this comment.
Thanks for the info! Added a fix for this in bd0801e.
boddumanohar
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the recent outage, failures accessing the simplyblock API flooded the controller log. The exception handling was inconsistent and relied on call-sites covering and translating errors. This changeset modifies the simplyblock API to always raise one specific error that can be caught.
Implementing this I got a bit carried away and addressed a few other concerns that popped up. Most notably
Reviewing this is probably most sensible to do commit-wise, they should be self-contained and descriptive.