Open
Conversation
mxsrc
force-pushed
the
fix-memory-limits
branch
from
c5d6620 to
dff780d
Compare
mxsrc
force-pushed
the
fix-memory-limits
branch
from
dff780d to
0df2eba
Compare
noctarius
reviewed
Feb 2, 2026
| MEMORY_MAX = 32 * GIB | ||
| MEMORY_STEP = 256 * MIB | ||
| AUTOSCALER_MEMORY_SLOT_SIZE_MIB = MEMORY_STEP // MIB | ||
| AUTOSCALER_MEMORY_SLOTS_MIN = MEMORY_MIN // AUTOSCALER_MEMORY_SLOT_SIZE_MIB |
Collaborator
There was a problem hiding this comment.
Wasn't there something like "the first chunk of memory must not be a virtio memory slot" and that's why we needed to split a chunk of normal memory and then memory slots?
Collaborator
Author
There was a problem hiding this comment.
Technically yes, but the autoscaler handles this transparently. The memory until the minimum is regular VM memory, anything beyond that is the pluggable memory but it's still talked about in terms of slots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory limits that are specified for the autoscaler have a few issues:
This PR