add env_types array to userroles assignment#471
Open
boddumanohar wants to merge 2 commits intomainfrom
Open
Conversation
77b88a0 to
a674a3b
Compare
a674a3b to
0d587f4
Compare
mxsrc
reviewed
Jan 7, 2026
Collaborator
mxsrc
left a comment
There was a problem hiding this comment.
Looks quite good, just a question regarding how we encode things in the database.
Collaborator
|
Looking at the code (and it makes sense) but this will change the API, won't it? I think there are one or two more calls which have env vars and retrieve a comma separated list right now. However, I assume these are already handled since the type check is happy. |
noctarius
requested changes
Jan 7, 2026
Collaborator
|
Since this also requires a change in the studio-backend code, let's not merge it immediately. I'll create the change tomorrow and merge it right after the studio is merged and deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when assigning a role of type
environmentto the user, if the env_types field has multiple values, we get 500 error.This PR fixes that issue by changing the env_type field to
env_typesof typearray.Testing
environmentUsertable for the Keycloak user created in step 1That works and the response body is: