Open
Conversation
boddumanohar
force-pushed
the
aws-updates
branch
from
481c35a to
d3e8fca
Compare
| } | ||
| } | ||
|
|
||
| variable "snode_deploy_on_k8s" { |
Collaborator
There was a problem hiding this comment.
why remove this variable
variable "snode_deploy_on_k8s" {
| while [[ $# -gt 0 ]]; do | ||
| arg="$1" | ||
| case $arg in | ||
| --max-lvol) |
Collaborator
There was a problem hiding this comment.
This parameter is required during sn configure which is done as part of terraform setup
| enabled = true | ||
|
|
||
| eks-nodes = { | ||
| desired_size = 2 |
Collaborator
There was a problem hiding this comment.
why remove the desired_size, min_size and max_size
aws/eks.tf
Outdated
| } | ||
| } | ||
|
|
||
| # resource "aws_eks_access_entry" "example" { |
Collaborator
There was a problem hiding this comment.
why comment the code?
| data "aws_caller_identity" "current" {} | ||
|
|
||
| locals { | ||
| volume_device_names = ["/dev/sdi", "/dev/sdj", "/dev/sdk", "/dev/sdl", "/dev/sdm", "/dev/sdn", "/dev/sdo"] |
Collaborator
There was a problem hiding this comment.
This logic allows us add more ebs volume per storage node
| } | ||
|
|
||
| # can be used for testing caching nodes | ||
| resource "aws_instance" "extra_nodes" { |
Collaborator
There was a problem hiding this comment.
We need this instance as we use it to deploy the master node of k3s
| EOF | ||
| } | ||
|
|
||
| resource "aws_ebs_volume" "storage_nodes_ebs" { |
Collaborator
There was a problem hiding this comment.
This change clearly removing the support for EBS backed storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the AWS code run on EKS only