Merged
Conversation
* use max_size instead as hugepage memory when set * fixed linter issue * fixed type check * fixed: Remove assignment to unused variable e * fixed: Remove extraneous prefix * comment out to using max_size value as hugpages * comment out max_size * setup ramdisk mount * use the max of huge_page_memory and max_size when max_size is set
This reverts commit 65ffd7b.
This reverts commit 5f0e729.
…nd container limit
…es (#859) and also add --format-4k to sn add-node to force format the nvme devices with 4K
- check new pcie against the current ssds list for the node - bind new devices to spdk driver
… task status accordingly
f2098f1 to
f584dbd
Compare
f584dbd to
21dc3b9
Compare
Hamdy-khader
approved these changes
Feb 5, 2026
geoffrey1330
approved these changes
Feb 5, 2026
a166050 to
83ad759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.