Skip to content

Fix sfam-2542 #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamdy-khader wants to merge 1 commit into
base: R25.10-Hotfix
Choose a base branch
from
Open

Fix sfam-2542 #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions simplyblock_core/storage_node_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,6 +2284,26 @@ def shutdown_storage_node(node_id, force=False):
if task.function_name != JobSchedule.FN_NODE_RESTART:
tasks_controller.cancel_task(task.uuid)

online_nodes_less_than_min_time = 0
for node in db_controller.get_storage_nodes_by_cluster_id(snode.cluster_id):
if node.online_since:
diff = datetime.datetime.now(datetime.timezone.utc) - datetime.datetime.fromisoformat(node.online_since)
if diff.total_seconds() < 15:
online_nodes_less_than_min_time += 1
break

if 0 < online_nodes_less_than_min_time <= 1:
cluster = db_controller.get_cluster_by_id(snode.cluster_id)
if cluster.distr_npcs == 1:
logger.error("Can not shutdown node now, must wait for at least 15 seconds when last node was online")
if force is False:
return False

elif online_nodes_less_than_min_time > 1:
logger.error("Can not shutdown node now, must wait for at least 15 seconds when last node was online")
if force is False:
return False

logger.info("Shutting down node")
set_node_status(node_id, StorageNode.STATUS_IN_SHUTDOWN)

Expand Down Expand Up @@ -2390,6 +2410,25 @@ def suspend_storage_node(node_id, force=False):
logger.error("Offline storage nodes found, cannot suspend node without --force")
return False

online_nodes_less_than_min_time = 0
for node in db_controller.get_storage_nodes_by_cluster_id(snode.cluster_id):
if node.online_since:
diff = datetime.datetime.now(datetime.timezone.utc) - datetime.datetime.fromisoformat(node.online_since)
if diff.total_seconds() < 15:
online_nodes_less_than_min_time += 1
break

if 0 < online_nodes_less_than_min_time <= 1:
if cluster.distr_npcs == 1:
logger.error("Can not shutdown node now, must wait for at least 15 seconds when last node was online")
if force is False:
return False

elif online_nodes_less_than_min_time > 1:
logger.error("Can not shutdown node now, must wait for at least 15 seconds when last node was online")
if force is False:
return False

logger.info("Suspending node")

for dev in snode.nvme_devices:
Expand Down
Loading