Skip to content

Resolve unhandled exception with non-string attributes #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdijen merged 1 commit into from
Feb 17, 2025
Merged

Resolve unhandled exception with non-string attributes #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Auth/Process/AttributeAddFromLDAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

use function array_values;

class AttributeAddFromLDAP extends BaseFilter

Check warning on line 19 in src/Auth/Process/AttributeAddFromLDAP.php

View workflow job for this annotation

GitHub Actions / Quality control

UnusedClass 

src/Auth/Process/AttributeAddFromLDAP.php:19:7: UnusedClass: Class SimpleSAML\Module\ldap\Auth\Process\AttributeAddFromLDAP is never used (see https://psalm.dev/075)
{
/**
* LDAP attributes to add to the request attributes
Expand Down Expand Up @@ -96,7 +96,7 @@
foreach ($attributes as $attr => $val) {
$arrSearch[] = '%' . $attr . '%';

if (is_array($val) && count($val) > 0 && strlen($val[0]) > 0) {
if (is_array($val) && count($val) > 0 && is_string($val[0]) && strlen($val[0]) > 0) {
$arrReplace[] = $this->connector->escapeFilterValue($val[0], true);
} else {
$arrReplace[] = '';
Expand Down
Loading