Skip to content

Fix message for the assertion #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdijen merged 1 commit into from
Jun 9, 2025
Merged

Fix message for the assertion #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Auth/Process/EntityCategory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*
* @package SimpleSAMLphp
*/
class EntityCategory extends Auth\ProcessingFilter

Check failure on line 24 in src/Auth/Process/EntityCategory.php

View workflow job for this annotation

GitHub Actions / Quality control

ClassMustBeFinal 

src/Auth/Process/EntityCategory.php:24:7: ClassMustBeFinal: Class SimpleSAML\Module\entitycategories\Auth\Process\EntityCategory is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)

Check warning on line 24 in src/Auth/Process/EntityCategory.php

View workflow job for this annotation

GitHub Actions / Quality control

UnusedClass 

src/Auth/Process/EntityCategory.php:24:7: UnusedClass: Class SimpleSAML\Module\entitycategories\Auth\Process\EntityCategory is never used (see https://psalm.dev/075)
{
/**
* A list of categories available. An associative array where the identifier of the category is the key, and the
Expand Down Expand Up @@ -104,7 +104,7 @@

Assert::string(
$index,
"Unspecified allowed attributes for the '$value' category.",
"Identifier of a category must be a string. '$index' is set.",
Error\ConfigurationError::class,
);

Expand All @@ -124,7 +124,7 @@
*
* @param array &$state The current request.
*/
public function process(array &$state): void

Check failure on line 127 in src/Auth/Process/EntityCategory.php

View workflow job for this annotation

GitHub Actions / Quality control

MissingOverrideAttribute 

src/Auth/Process/EntityCategory.php:127:5: MissingOverrideAttribute: Method SimpleSAML\Module\entitycategories\Auth\Process\EntityCategory::process should have the "Override" attribute (see https://psalm.dev/358)
{
if (!array_key_exists('EntityAttributes', $state['Destination'])) {
if ($this->strict === true) {
Expand Down
Loading