Skip to content

Dockerfile improvement #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WolfangAukang wants to merge 9 commits into from
Closed

Dockerfile improvement #114

WolfangAukang wants to merge 9 commits into from

Conversation

@WolfangAukang
Copy link
Contributor

@WolfangAukang WolfangAukang commented May 15, 2025 •
edited
Loading

  • Using a single Dockerfile for both images, relying on ARG to change the corresponding image version
  • Use separate stage to download bundle
  • Use ENV for application version instead of writing to /tmp

@WolfangAukang
simplerisk-minimal: refactor Dockerfile
76b3c5b 
Now using a single Dockerfile, handling PHP versions through ARG, downloading SimpleRisk through another stage, having a single COPY for common components and updating the workflows to use build-args
@WolfangAukang
simplerisk-minimal: perform some hadolint fixes
2f7f49c
@WolfangAukang WolfangAukang changed the title Dockerfile improvement WIP: Dockerfile improvement May 15, 2025
@WolfangAukang
ci: fix description
ac845c2
@WolfangAukang
simplerisk: refactor Dockerfile
339a53f 
Now using a single Dockerfile, handling Ubuntu version through ARG, downloading SimpleRisk through another stage, having a single COPY for common components and updating the workflows to use build-args
@WolfangAukang
simplerisk-minimal: format
3981efb
@WolfangAukang WolfangAukang marked this pull request as ready for review May 16, 2025 13:48
@WolfangAukang WolfangAukang changed the title WIP: Dockerfile improvement Dockerfile improvement May 16, 2025
@WolfangAukang WolfangAukang mentioned this pull request Jul 10, 2025
Merged
@WolfangAukang WolfangAukang deleted the multistage branch August 22, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WolfangAukang