Disable HTTP/2 as workaround for nginx bug #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
As an aside, this repo has issues disabled- if that's intentional, don't mind me, but I thought I'd bring it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the version of nginx running on your production servers has a bug with HTTP/2. I'm receiving the same error when using the library-
2017/03/09 19:49:26 Post https://api.simplepush.io/send: stream error: stream ID 1; REFUSED_STREAMAs a workaround for this, HTTP/2 can be disabled by setting http.Transport.TLSNextProto to a non-nil, empty map. The end of the net/http package overview gives details on this. Alternatively, nginx could be upgraded- it appears that nginx 1.11.0 has the necessary fix though I haven't played with this myself. I can confirm that this does fix the problem when testing against my personal key.
Thanks for putting together the service and library, it's a joy to use.