Guard transform when --detect-types CSV has only a header row (closes #702)#733
Open
guzenkopavel wants to merge 1 commit intosimonw:mainfrom
Open
Guard transform when --detect-types CSV has only a header row (closes #702)#733guzenkopavel wants to merge 1 commit intosimonw:mainfrom
guzenkopavel wants to merge 1 commit intosimonw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #702.
When
sqlite-utils insert --csv --detect-typesis given a CSV file that contains only the header row (no data rows), the table is never created — but the post-insert call todb.table(table).transform(types=tracker.types)still runs and trips an assertion:This adds the
db.table(table).exists()guard suggested by the issue author (@nis-djom), plus a regression test (tests/test_cli.py::test_insert_detect_types_header_only_csv) that exercises the exact scenario from the issue body.Local
pytest -qon the patched branch: 1041 passed, 16 skipped, 6.40s.📚 Documentation preview 📚: https://sqlite-utils--733.org.readthedocs.build/en/733/