Skip to content

feat: recreate fts triggers after table transform#499

Open
chapmanjacobd wants to merge 1 commit intosimonw:mainfrom
chapmanjacobd:patch-3
Open

feat: recreate fts triggers after table transform#499
chapmanjacobd wants to merge 1 commit intosimonw:mainfrom
chapmanjacobd:patch-3

Conversation

@chapmanjacobd
Copy link
Copy Markdown
Contributor

@chapmanjacobd chapmanjacobd commented Oct 11, 2022

#498


📚 Documentation preview 📚: https://sqlite-utils--499.org.readthedocs.build/en/499/

alternatively, self.disable_fts()

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 11, 2022

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.25%. Comparing base (d792dad) to head (a25e838).
⚠️ Report is 196 commits behind head on main.

Files with missing lines Patch % Lines
sqlite_utils/db.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   96.37%   96.25%   -0.12%     
==========================================
  Files           4        4              
  Lines        2401     2406       +5     
==========================================
+ Hits         2314     2316       +2     
- Misses         87       90       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chapmanjacobd
Copy link
Copy Markdown
Contributor Author

chapmanjacobd commented Oct 26, 2022

The problem with how it is currently is that the transformed fts table will return incorrect results (unless the table was only 1 row or something), even if create_triggers was enabled previously. Maybe the simplest solution is to disable fts on a transformed table rather than try to recreate it? Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant