bugfix: added term to shear estimator with l1 <--> l2 swapped#10
Open
abaleato wants to merge 1 commit into
Open
bugfix: added term to shear estimator with l1 <--> l2 swapped#10abaleato wants to merge 1 commit into
abaleato wants to merge 1 commit into
Conversation
The auto- and cross-spectra (with the true lensing potential) of shear reconstructions were previously biased low. With this bugfix, we recover the expected behaviour. It might not be the fix that best fits the style of the code, but I hope it is a good starting point for a more elegant and permanent one.
Member
|
Hi @abaleato thanks for contributing this. I'll have a look. Did you mean to close it though? |
Author
|
Hi @msyriac. Well, I decided I wanted to run some more tests before bothering you, but I was too clumsy to even backtrack on my steps! Let me know what you think: I am quite sure that there's a bug, but I'd appreciate you checking also. |
|
If I remember correctly there was some difference in the formula of the large scale limit shear estimator between Schaan-Ferraro 2018 v1 vs v2 on arxiv, hence the bug. I think there were a few small changes to make it consistent (I believe to make it work with asymmetric maps too). When I have time I will check my clone of symlens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mat. Thanks for making this great code available! I think I have found and corrected a small bug. The auto- and cross-spectra (with the true lensing potential) of shear reconstructions were previously biased low. With this bugfix, we recover the expected behaviour, while passing all existing tests. It might not be the fix that best fits the style of the code, but I hope it is a good starting point for a more elegant and permanent one.