Improvements to LoadContext and wobble correction operator#1649
Open
tskisner wants to merge 1 commit into
Open
Improvements to LoadContext and wobble correction operator#1649tskisner wants to merge 1 commit into
tskisner wants to merge 1 commit into
Conversation
- Update LoadContext to load hwp, boresight rotation, and corotator angles by default if they exist. Additional small fixes. - Implement new operator to apply wobble correction metadata to the boresight pointing.
AERAdler
reviewed
May 29, 2026
Contributor
AERAdler
left a comment
AERAdler
left a comment
There was a problem hiding this comment.
Has the HWP wobble operator been tested?
Member
Author
|
For testing, I only tested in a notebook with satp1 data. The implementation copies the order of quaternion rotations in the code here. I guess I could test this artificially (without access to real data in CI tests) by adding fake wobble parameters in the observation and also manually calling the so3g function. I'll go do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update LoadContext to load hwp, boresight rotation, and corotator angles by default if they exist. Additional small fixes.
Implement new operator to apply wobble correction metadata to the boresight pointing.