Sdw filter for sources pca map#1646
Merged
Merged
Conversation
added 2 commits
May 24, 2026 16:22
…utput, changes preprocess.processes accordingly
mmccrackan
approved these changes
May 26, 2026
Contributor
mmccrackan
left a comment
mmccrackan
left a comment
There was a problem hiding this comment.
Looks good to me, just one point regarding the docstring.
| source_flags: "source_flags" | ||
| edge_guard: 10 # Number of samples to make the first and last flags False | ||
| trim_samps: 100 | ||
| pca_wrap: "pca_model" # optional, if provided, the PCA model is wrapped into proc_aman under this name |
Contributor
There was a problem hiding this comment.
It is wrapped under aman not proc_aman right?
Contributor
Author
There was a problem hiding this comment.
ah shoot I totally didn't see this comment, yes it is under aman, but isn't that only after proc_aman gets wrapped into aman?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows option to wrap calcualted pca modes and weights to the axis manager when calling filter_for_sources. We want this for the planet map maker so we can map the modes being removed. Also changes the process.py file accordingly to be able to use this new feature in a preprocess configuration file.