update how HK database delays are processed#1644
Open
kmharrington wants to merge 3 commits into
Open
Conversation
JBorrow
approved these changes
May 25, 2026
Member
JBorrow
left a comment
JBorrow
left a comment
There was a problem hiding this comment.
Some minor clarity patches but looks good
| ) | ||
| ## this will catch suprsync drops and hk/g3tsmurf databases not being updated | ||
| if final_time < max_ctime: | ||
| if max_ctime - final_time > 3600*incomplete_timeouts[1]: |
Member
There was a problem hiding this comment.
For clarity:
Suggested change
| if max_ctime - final_time > 3600*incomplete_timeouts[1]: | |
| if (max_ctime - final_time) > (3600 * incomplete_timeouts[1]): |
| f"G3tSMURF + HK databases are stale. Last updates were " | ||
| f"more than {incomplete_timeouts[1]} hours in the past." | ||
| ) | ||
| if max_ctime - final_time > 3600*incomplete_timeouts[0]: |
Member
There was a problem hiding this comment.
Suggested change
| if max_ctime - final_time > 3600*incomplete_timeouts[0]: | |
| if (max_ctime - final_time) > (3600 * incomplete_timeouts[0]): |
| HK = self.get_HK() | ||
| last_update = HK.get_last_update() | ||
| if stop > last_update: | ||
| if stop > last_update + 2*3600: |
Member
There was a problem hiding this comment.
Suggested change
| if stop > last_update + 2*3600: | |
| if stop > (last_update + 2 * 3600): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a hardcoded 1 hour delay as the acceptable limit for HK database updates compared to when imprinter was searching for new books. This is getting broken with the new HK suprsyncs.
This fixes that and moves the logic for where the error message gets thrown. We'll match the warning / error timeouts to what is used for incomplete observations.