Account for tube orientation in det match#1627
Draft
mmccrackan wants to merge 9 commits into
Draft
Conversation
Member
|
The unit test failures here are due to an interplay between the latest toast wheels and the so3g wheels. I'm debugging in a separate PR. |
added 2 commits
May 18, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for #1603 into det match to properly account for ASO tube orientation.
Adds matching support for LF wafers all at once. If input wafer is
ws., it will first check the imprinter file and find the wafers and wafer_slots. It will then get the wafer_info for each of those wafers, select det_id's that are for the correct wafer, store these as a list, then merge all of them at the end. Also addsignore_north_southoption since this is not relevant for LF.