Depth1 mapmaking script refactoring

[iparask]

Trying to integrate mapcat to the depth1 mapmaking script, I realized that it was too difficult for me to move around. So I suggest the following refactoring as the first step. I think more cleaning needs to happen as there are functions that are not used at all.

Let me know what you think and how we can make it better.

[mhasself]

There's already a site_pipeline.util, so we're not going to add a .utils :)

Maybe put these functions in sotodlib.mapmaking.depth1_utils ?

This PR isn't only whitespace / organizational changes... this version has stopped writing the .empty files. Is everyone on board with that?

[iparask]

With the integration of the DB, there is no reason for the empty files. This is my understanding at least. @chervias can you verify?

There's already a site_pipeline.util, so we're not going to add a .utils :)
Maybe put these functions in sotodlib.mapmaking.depth1_utils ?

I thought they would overpopulate the util.py file in site-pipeline, that is why the folder. I can move them under mapmaking but that would make mapcat a general dependency where now is just a site dependency (see here).

[mhasself]

There's already a site_pipeline.util, so we're not going to add a .utils :)
Maybe put these functions in sotodlib.mapmaking.depth1_utils ?

I thought they would overpopulate the util.py file in site-pipeline, that is why the folder. I can move them under mapmaking but that would make mapcat a general dependency where now is just a site dependency (see here).

The folder is ok, but then take "util.py" and turn it into "util" directory. Frankly I don't mind if you rename util to utils, for all purposes -- that's what most other parts of sotodlib call their utils. Either way (util or utils) it would be best to do such refactoring in a separate PR, into master, and then merge back here to add more stuff in.

[chervias]

With the integration of the DB, there is no reason for the empty files. This is my understanding at least. @chervias can you verify?

Yes, I think the empty files are a leftover from the ACT depth-1 mapmaker by Sigurd. Now that we use a completely new way of tracking the maps, I don't think we need them anymore