Conversation
… AstroPydanticTime
…d updating test client to Time
JBorrow
left a comment
JBorrow
left a comment
There was a problem hiding this comment.
Looks good apart from one thing (which I may have missed). I'd like to have a single unified function on the client that calls both fixed and moving and returns them as two lists.
| @abstractmethod | ||
| def delete_ephem(self, *, ephem_id: int) -> None: | ||
| def update_sso( | ||
| self, *, solar_id: int, name: str | None, MPC_id: int | None |
There was a problem hiding this comment.
is solar_id different from sso_id?
There was a problem hiding this comment.
No they should be the same, looks like it's just these functions that use solar_id, I'll change em over.
axf295
left a comment
axf295
left a comment
There was a problem hiding this comment.
looks great - some places where times were ints ... not sure if those were internal and fine, or missed
| sso_id: int | None, | ||
| MPC_id: int | None, | ||
| name: str | None, | ||
| time: int | None, |
There was a problem hiding this comment.
should this be time: Time | none ?
| async def get_time_box( | ||
| lower_left: ICRS, | ||
| upper_right: ICRS, | ||
| start_time: int, |
There was a problem hiding this comment.
They were missed, just call out the ones I should change.
|
@JBorrow yeah that feature is on the docket to-do but I wanted to give Allen the tools he needed ahead of time. |
|
@JBorrow requested feature is now in |
|
Is it possible to implement this on the clients? So |
|
Yeah can do. |
|
Love it. @axf295 is this what we're looking for? |
axf295
left a comment
axf295
left a comment
There was a problem hiding this comment.
this looks like exactly what I want!
will try to get to testing it tomorrow
3 participants
Update
get_boxto two functions, one for fixed sourcesget_box_fixedand the other for ssosget_box_sso. In order to makeget_box_ssowork withclient.mock, I had to makeephem_catan argument ofmock.get_box_sso, since intrinsically withmockone DB does not know about another DB. This does make the parameters ofmock.get_box_ssoanddb.get_box_ssodifferent fromcore.get_box_sso. This PR also switches every instance of time in the DB fromintunix time toastropy.time.Timeordatetime, as appropriate.