Don't run det setup if too short#363
Open
mmccrackan wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a det setup is only being run due to the cadence (i.e detectors are set up, no boresight rotation or elevation change and not a cal observation) and the scan is too short, do not run detector setup and just run the scan as is. This will catch cases where a remainder scan (~10-20 min) will want to do a detector setup, but will get completely cut leaving an empty spot. It should not be possible to get several of these cases in a row.
Also trims the ends of the blocks to the constraint if they go beyond it. Previously, the block was only cut after pre-ops were calculated, so the above detector setup could still get scheduled.