Skip to content

Lensing can read sacc and fiducial file#213

Closed
ggalloni wants to merge 9 commits into
masterfrom
lensing_sacc
Closed

Lensing can read sacc and fiducial file#213
ggalloni wants to merge 9 commits into
masterfrom
lensing_sacc

Conversation

@ggalloni
Copy link
Copy Markdown
Collaborator

This PR fixes #60

  • Possibility to read the fiducial from a file.
  • Reading the correction factors from a sacc file.
  • @mgerbino I am not sure about the "move theory calculations" point. Do you have any suggestions?

Also,

  • Probably we should modify the installation files

@ggalloni ggalloni added the enhancement New feature or request label Sep 25, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.35%. Comparing base (5adba45) to head (1218244).

Files with missing lines Patch % Lines
soliket/lensing/lensing.py 40.00% 28 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   83.79%   82.35%   -1.44%     
==========================================
  Files          35       35              
  Lines        1641     1678      +37     
  Branches      146      149       +3     
==========================================
+ Hits         1375     1382       +7     
- Misses        206      234      +28     
- Partials       60       62       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mgerbino
Copy link
Copy Markdown
Collaborator

@ggalloni, I believe we can skip that part. It was intended to mirror the "old" structure of mflike, when everything that wasn't data preparation and loglike computation was included in a separate module (theoryforge). Since that structure is no longer in place, there is no need to implement it here. Thanks for checking!

@ggalloni
Copy link
Copy Markdown
Collaborator Author

ggalloni commented Oct 6, 2025

I am closing this as it is superseded by #218.

@ggalloni ggalloni closed this Oct 6, 2025
@ggalloni ggalloni deleted the lensing_sacc branch April 14, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update lensing likelihood

3 participants