This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Updating logic, simplifying requirements, and adding shuffle all#1
Open
johnpacheco1 wants to merge 4 commits intosimonsickle:mainfrom
Open
Updating logic, simplifying requirements, and adding shuffle all#1johnpacheco1 wants to merge 4 commits intosimonsickle:mainfrom
johnpacheco1 wants to merge 4 commits intosimonsickle:mainfrom
Conversation
simonsickle
approved these changes
Oct 16, 2022
Owner
simonsickle
left a comment
There was a problem hiding this comment.
This is awesome! One small request if you don't mind, though!
For maintainability and code quality, could you make the code copied to the "all" script shared (maybe through a module and classes).
That's a pretty big ask, so if you don't feel like taking that on let me know and I'll add a TODO for me to revisit in the future.
Thanks for the contribution
Author
|
I will give it a shot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I just wanted to thank you @simonsickle for creating this! I recently got a tesla and have been annoyed by Tidal's lack of a shuffle feature. I was going to attempt to write a similar program to what you have created when I happened on this!
Changes:
README.md
requirements.txt
ElectricShuffle.py
**ElectricShuffleAll.py"