Skip to content

Conversation

@TomAFrench
Copy link
Collaborator

This PR fixes a few issues introduced in #115, notably:

  • The space was lost between the macro label and the base quantity, i.e. "kcal per100 g" instead of "kcal per 100 g"
  • The default 100g was still included in some internationalisation entries which resulted in "protein per 100 gper100g"

I've updated the .arb files but it's not entirely clear how I should regenerate the localisations.

Running dart run package:intl/generate_localized.dart as suggested in the existing generated files just results in the error Could not find file 'package:intl/generate_localized.dart' Based on flutter_intl in the pubspec.yaml file it looks like you're using this extension for intl but if I regenerate the intl files using that then it results in a few hundred new entries.

Feel free to push the updated intl files onto this branch directly but it would be nice to have a documented process for how to regenerate these.

@TomAFrench
Copy link
Collaborator Author

TomAFrench commented May 18, 2025

Looks like @shoutingcatana also brought up the issue of developer documentation on how intl is done. I'd be happy to set up a CI check to ensure that the generated intl files are correctly generated if you can share some pointers on what the process is.

@TomAFrench TomAFrench changed the base branch from main to develop May 18, 2025 22:09
@TomAFrench TomAFrench force-pushed the tf/fix-base-quantity-labels branch from c51e3b2 to b949d47 Compare May 18, 2025 22:10
@TomAFrench TomAFrench mentioned this pull request Jun 5, 2025
@TomAFrench TomAFrench force-pushed the tf/fix-base-quantity-labels branch from 052a4f0 to d0fed16 Compare August 12, 2025 00:13
@TomAFrench TomAFrench changed the base branch from develop to tf/enforce-intl-in-ci August 12, 2025 00:14
@TomAFrench TomAFrench marked this pull request as draft August 12, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant