test: Avoid -ffinite-math-only on floating point comparisons #1373
+42
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `-ffinite-math-only` (implied by `-ffast-math` and -Ofast), GCC considers all comparisons against infinities to be false and can optimize them away. This breaks several tests that rely on infinities to be compared correctly. To avoid this, we add GCC-specific optimize attribute that disables `-ffinite-math-only` optimization for floating point comarisions used in assertions. Signed-off-by: Ivan A. Melnikov <iv@altlinux.org>
From the GCC manual page: > Disregard strict standards compliance. -Ofast enables all -O3 optimizations. > It also enables optimizations that are not valid for all standard-compliant > programs. It turns on -ffast-math, -fallow-store-data-races. > It turns off -fsemantic-interposition. On recent clang, use "-O3 -ffast-math" due to > error: argument '-Ofast' is deprecated; use '-O3 -ffast-math' for the same > behavior, or '-O3' to enable only conforming optimizations > [-Werror,-Wdeprecated-ofast]
mr-c
force-pushed
the
tests-no-finite-math-only
branch
from
30e03ea to
cea5dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
-ffinite-math-only(implied by-ffast-mathand -Ofast), GCC considers all comparisons against infinities to be false and can optimize them away. This breaks several tests that rely on infinities to be compared correctly. To avoid this, we add GCC-specific optimize attribute that disables-ffinite-math-onlyoptimization for floating point comarisions used in assertions.