feat: support attached databases #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pmorris-dev
commented
Jan 8, 2026
pmorris-dev
commented
- This PR plumbs the feature through (TS -> commands -> wrapper)
- Introducing a new builder pattern to chain the attach() fn
- The attach() fn can be chained with any query fn
- This prevents introducing optional attached db params everywhere
- Unfortunately we never set up eslint in this repo so this PR adds that
- This has resulted in a lot of changes to the TS files
- However this is a good time to do it because the builder pattern meant significant changes to the TS anyway
- Also doubled back to add tests for the new attached.rs API which was added in the last PR
pmorris-dev
force-pushed
the
support_attached_databases
branch
5 times, most recently
from
65359d9 to
1112230
Compare
jjhafer
requested changes
Jan 12, 2026
- This PR plumbs the feature through (TS -> commands -> wrapper)
- Introducing a new builder pattern to chain the attach() fn
- The attach() fn can be chained with any query fn
- This prevents introducing optional attached db params everywhere
- Unfortunately we never set up eslint in this repo so this PR adds that
- This has resulted in a lot of changes to the TS files
- However this is a good time to do it because the builder pattern
meant significant changes to the TS anyway
- Also doubled back to add tests for the new attached.rs API which was
added in the last PR
pmorris-dev
force-pushed
the
support_attached_databases
branch
from
1112230 to
48a48fc
Compare
jjhafer
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.