dev: eslint exclude dist to not JavaScript heap out of memory#3870
Open
dev: eslint exclude dist to not JavaScript heap out of memory#3870
Conversation
`npm run lint` includes processing files in ClientApp/dist. If lots of files build up in there over time, then `npm run lint` can hit "JavaScript heap out of memory" and fail.
There was a problem hiding this comment.
Pull request overview
This PR prevents npm run lint from scanning generated build output under ClientApp/dist, avoiding excessive memory usage (e.g., “JavaScript heap out of memory”) when that directory accumulates files over time.
Changes:
- Exclude
dist(andnode_modules) from the rootClientApp/tsconfig.jsonTypeScript project scope. - Add
dist/**/*to the top-level ESLint flat configignoreslist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SIL.XForge.Scripture/ClientApp/tsconfig.json | Excludes dist/node_modules from the base TS project so tooling using this tsconfig doesn’t traverse build output. |
| src/SIL.XForge.Scripture/ClientApp/eslint.config.mjs | Ignores dist content so ESLint doesn’t lint built artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3870 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 630 630
Lines 40592 40592
Branches 6588 6564 -24
=======================================
Hits 32898 32898
- Misses 6661 6674 +13
+ Partials 1033 1020 -13 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run lintincludes processing files in ClientApp/dist. If lots offiles build up in there over time, then
npm run lintcan hit"JavaScript heap out of memory" and fail.
This change is