serval-admin: serval-builds: add training book total summary stats#3866
Open
serval-admin: serval-builds: add training book total summary stats#3866
Conversation
There was a problem hiding this comment.
Pull request overview
Adds additional summary statistics to the Serval Admin “Serval builds” view so admins can see aggregate training-book totals (both deduped and non-deduped) for the currently visible build rows.
Changes:
- Extended
ServalBuildSummaryto includetotalUniqueTrainingBooksandtotalTrainingBooks. - Implemented unique-book counting (
countUniqueBooks) and populated both totals inbuildSummary. - Added/updated unit tests to validate total vs. unique training book counting across builds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.ts | Adds new summary fields and displays them as hidden summary items in the builds UI. |
| src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.spec.ts | Adds assertions and a dedicated test covering total vs. unique training book counts. |
| src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds-statistics.ts | Adds countUniqueBooks and computes/publishes the new training book totals in buildSummary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3866 +/- ##
==========================================
+ Coverage 81.04% 81.05% +0.01%
==========================================
Files 630 630
Lines 40592 40605 +13
Branches 6588 6588
==========================================
+ Hits 32898 32914 +16
Misses 6661 6661
+ Partials 1033 1030 -3 ☔ View full report in Codecov by Sentry. |
This adds information to the summary area regarding "Total unique training books" and "Total training books". I plan to do similar for translation books in followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds information to the Serval builds tab in the summary area. The new items are
"Total unique training books" and
"Total training books". I plan to do similar for translation books in followup.
Screenshot (you can ignore the numbers in this poor example):
This change is