Make it clear when project has no Serval build warnings#3857
Open
Make it clear when project has no Serval build warnings#3857
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3857 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 630 630
Lines 40594 40594
Branches 6588 6588
=======================================
Hits 32900 32900
Misses 6674 6674
Partials 1020 1020 ☔ View full report in Codecov by Sentry. |
Nateowami
force-pushed
the
feature/clarify-no-build-warnings
branch
from
15e442e to
bd1d94a
Compare
Contributor
|
✅ No screenshot differences — all stories are identical. View the diff page at: https://pr-3857--sf-screenshot-diffs.netlify.app |
marksvc
approved these changes
May 8, 2026
Collaborator
marksvc
left a comment
marksvc
left a comment
There was a problem hiding this comment.
@marksvc reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think when I originally added this section to the page, the warnings weren't being produced yet, so a lack of warnings in the data didn't really mean a lack of problems. However, now that the feature is working and something the team looks at, it's better to be clear whether when there are no warnings and why.
This change is