serval-admin: serval-builds: rename column Source to Translation#3853
serval-admin: serval-builds: rename column Source to Translation#3853
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Serval builds administration UI to better reflect the meaning of the “source” column by renaming its header label to “Translation”, aligning the table header with the underlying row.translationBooks content.
Changes:
- Renamed the “Source” table column header to “Translation” in the Serval builds table.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9d2b5b3 to
e784bad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3853 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 630 630
Lines 40592 40592
Branches 6588 6588
=======================================
Hits 32898 32898
Misses 6661 6661
Partials 1033 1033 ☔ View full report in Codecov by Sentry. |
|
Why? I think this is more ambiguous than the previous wording. Did we come to this decision in the meeting? |
|
No. And I prefer "Source". I'm seeking to use terminology that I thought EITL or Serval have been using. As part of inserting a new column for the Training project and books (in another PR), I am renaming "Source" to "Translation" so the columns can be distinguished according to whether they match the Training books or the Translation books. I'm looking to see why I thought "Translation" was a term being used. I see BuildConfig.cs Well. I'll cancel this PR? |
e784bad to
a2037d9
Compare
Screenshot showing column "Translation":

This change is