Skip to content

serval-admin: serval-builds: rename column Source to Translation#3853

Open
marksvc wants to merge 1 commit intomasterfrom
task/sb-columnName
Open

serval-admin: serval-builds: rename column Source to Translation#3853
marksvc wants to merge 1 commit intomasterfrom
task/sb-columnName

Conversation

@marksvc
Copy link
Copy Markdown
Collaborator

@marksvc marksvc commented May 6, 2026

Screenshot showing column "Translation":
image

This change is Reviewable

@marksvc marksvc requested a review from Copilot May 6, 2026 22:56
@marksvc marksvc added e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete labels May 6, 2026
@marksvc marksvc marked this pull request as draft May 6, 2026 22:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Serval builds administration UI to better reflect the meaning of the “source” column by renaming its header label to “Translation”, aligning the table header with the underlying row.translationBooks content.

Changes:

  • Renamed the “Source” table column header to “Translation” in the Serval builds table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marksvc marksvc force-pushed the task/sb-columnName branch from 9d2b5b3 to e784bad Compare May 6, 2026 22:58
@marksvc marksvc changed the title ui: rename source column translation serval-admin: serval-builds: rename column Source to Translation May 6, 2026
@marksvc marksvc added testing not required and removed will require testing PR should not be merged until testers confirm testing is complete e2e Run e2e tests for this pull request labels May 6, 2026
@marksvc marksvc marked this pull request as ready for review May 6, 2026 23:00
@marksvc marksvc temporarily deployed to screenshot_diff May 6, 2026 23:04 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (1feb822) to head (a2037d9).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3853   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files         630      630           
  Lines       40592    40592           
  Branches     6588     6588           
=======================================
  Hits        32898    32898           
  Misses       6661     6661           
  Partials     1033     1033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami
Copy link
Copy Markdown
Collaborator

Why? I think this is more ambiguous than the previous wording. Did we come to this decision in the meeting?

@Nateowami Nateowami self-assigned this May 8, 2026
@marksvc
Copy link
Copy Markdown
Collaborator Author

marksvc commented May 8, 2026

No. And I prefer "Source". I'm seeking to use terminology that I thought EITL or Serval have been using. As part of inserting a new column for the Training project and books (in another PR), I am renaming "Source" to "Translation" so the columns can be distinguished according to whether they match the Training books or the Translation books.

I'm looking to see why I thought "Translation" was a term being used. I see BuildConfig.cs TranslationScriptureRanges. I am not seeing it in the Configure draft sources page. It looks like we set a Serval TranslationBuildConfig.Pretranslate that includes our TranslationScriptureRanges. Oh, the draft-jobs tab lists "Training Books" and "Translation Books"; that's probably why I had items named that way in the Serval builds tab.

Well. I'll cancel this PR?

@marksvc marksvc force-pushed the task/sb-columnName branch from e784bad to a2037d9 Compare May 8, 2026 18:46
@marksvc marksvc temporarily deployed to screenshot_diff May 8, 2026 18:53 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants