Skip to content

SF-3774 Do not list books to translate as not enough data to train#3848

Open
pmachapman wants to merge 2 commits intomasterfrom
fix/SF-3774
Open

SF-3774 Do not list books to translate as not enough data to train#3848
pmachapman wants to merge 2 commits intomasterfrom
fix/SF-3774

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented May 5, 2026

This PR fixes a bug where books selected for drafting were still being displayed under the list of hidden books.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (b5a2eb0) to head (0a91018).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3848   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files         630      630           
  Lines       40590    40594    +4     
  Branches     6588     6564   -24     
=======================================
+ Hits        32896    32900    +4     
- Misses       6661     6674   +13     
+ Partials     1033     1020   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 self-assigned this May 6, 2026
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix and tests. Just a minor comment.

@RaymondLuong3 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts line 141 at r1 (raw file):

  unusableTranslateTargetBooks: number[] = [];
  emptyTranslateSourceBooks: number[] = [];
  trainingBooksWithoutEnoughData: number[] = [];

It looks like you can make this private. There is just one place it is referenced in the test. You can probably just remove that check.

Code quote:

  trainingBooksWithoutEnoughData: number[] = [];

Copy link
Copy Markdown
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmachapman made 1 comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).


src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts line 141 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

It looks like you can make this private. There is just one place it is referenced in the test. You can probably just remove that check.

Done.

@pmachapman pmachapman temporarily deployed to screenshot_diff May 6, 2026 19:22 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels May 7, 2026
@pmachapman pmachapman temporarily deployed to screenshot_diff May 7, 2026 22:37 — with GitHub Actions Inactive
@RaymondLuong3 RaymondLuong3 added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants