SF-3774 Do not list books to translate as not enough data to train#3848
SF-3774 Do not list books to translate as not enough data to train#3848pmachapman wants to merge 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3848 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 630 630
Lines 40590 40594 +4
Branches 6588 6564 -24
=======================================
+ Hits 32896 32900 +4
- Misses 6661 6674 +13
+ Partials 1033 1020 -13 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
left a comment
There was a problem hiding this comment.
Nice fix and tests. Just a minor comment.
@RaymondLuong3 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts line 141 at r1 (raw file):
unusableTranslateTargetBooks: number[] = []; emptyTranslateSourceBooks: number[] = []; trainingBooksWithoutEnoughData: number[] = [];
It looks like you can make this private. There is just one place it is referenced in the test. You can probably just remove that check.
Code quote:
trainingBooksWithoutEnoughData: number[] = [];
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts line 141 at r1 (raw file):
Previously, RaymondLuong3 (Raymond Luong) wrote…
It looks like you can make this private. There is just one place it is referenced in the test. You can probably just remove that check.
Done.
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
This PR fixes a bug where books selected for drafting were still being displayed under the list of hidden books.
This change is