serval-admin: serval-builds: add SF project ID filter by marksvc · Pull Request #3846 · sillsdev/web-xforge

marksvc · 2026-05-05T21:15:10Z

This allows showing only Serval builds that correspond to a particular
project. It can be tested by adding &sfProjectId=FOO to the URL.

Screenshot:

This change is

This allows showing only Serval builds that correspond to a particular project. It can be tested by adding `&sfProjectId=FOO` to the URL.

Copilot

Pull request overview

Adds an sfProjectId query-parameter-driven filter to the Serval Builds admin view so admins can restrict the build list (and summary stats) to a single Scripture Forge project, with a UI notice and “clear filter” action.

Changes:

Listen to sfProjectId in query params and apply a project filter to the builds table + summary.
Resolve and display a human-friendly project name for the active filter (fallback to raw ID).
Add UI notice + styling for the active filter and add unit tests for filter behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.ts	Adds query-param listening, filter state, filter-clearing navigation, and row filtering logic.
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.html	Shows an on-page notice when a project filter is active and provides a “Show all projects” action.
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.scss	Styles the new filter notice layout and adjusts notice margins.
src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.spec.ts	Adds tests covering filtering behavior when `sfProjectId` is set/cleared and updates DI setup for routing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RaymondLuong3 · 2026-05-05T22:15:56Z

+    combineLatest([
+      this.route.queryParams.pipe(map(params => params['sfProjectId'])),
+      this.onlineStatusService.onlineStatus$,
+      this.dateRange$.pipe(filter(notNull))
+    ])


This does look like it was not the intention of this change to reload when switching tabs. Probably the distinctUntilChange pipe is the right choice here

I think with the current implementation, it's not significant to use distinctUntilChanged, because if the user switches tabs, ServalBuildComponent I think is going to be destroyed, and another component is going to be shown. I suppose other URL parameters could get changed that the current page could start to use for something, like pagination. I have added distinctUntilChanged.

+          const projectDoc = await this.servalAdministrationService.get(projectFilterId);
+          displayName = projectDoc?.data != null ? projectLabel(projectDoc.data) : projectFilterId;
+        } catch {
+          // Filter can reference a deleted project; fall back to the raw ID
+        }


codecov · 2026-05-05T21:45:42Z

Codecov Report

❌ Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.01%. Comparing base (b1f7a61) to head (d92dd62).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...p/serval-administration/serval-builds.component.ts	48.00%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3846      +/-   ##
==========================================
- Coverage   81.03%   81.01%   -0.02%     
==========================================
  Files         630      630              
  Lines       40577    40596      +19     
  Branches     6574     6583       +9     
==========================================
+ Hits        32880    32889       +9     
- Misses       6666     6685      +19     
+ Partials     1031     1022       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RaymondLuong3

@RaymondLuong3 reviewed 4 files and all commit messages, and made 4 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on marksvc).

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.html line 41 at r2 (raw file):

  </div>

  @if (currentProjectFilter) {

Nit: This should be explicit currentProjectFilter != null

Code quote:

  @if (currentProjectFilter) {

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.html line 49 at r2 (raw file):

        <button mat-button class="clear-filter-btn" (click)="clearProjectFilter()">
          <mat-icon>filter_alt_off</mat-icon>
          <span>Show all projects</span>

Thanks for the helpful label!

Code quote:

          <span>Show all projects</span>

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.spec.ts line 97 at r2 (raw file):

      const rowA = env.createRowWithDetails({ projectId: 'project-a', startDate: new Date('2024-01-03T00:00:00Z') });
      const rowB = env.createRowWithDetails({ projectId: 'project-b', startDate: new Date('2024-01-02T00:00:00Z') });
      const rowC = env.createRowWithDetails({ projectId: 'project-a', startDate: new Date('2024-01-01T00:00:00Z') });

It looks like these projects can be added in a beforeEach for this describe.

Code quote:

      const rowA = env.createRowWithDetails({ projectId: 'project-a', startDate: new Date('2024-01-03T00:00:00Z') });
      const rowB = env.createRowWithDetails({ projectId: 'project-b', startDate: new Date('2024-01-02T00:00:00Z') });
      const rowC = env.createRowWithDetails({ projectId: 'project-a', startDate: new Date('2024-01-01T00:00:00Z') });

RaymondLuong3 · 2026-05-05T22:15:56Z

+    combineLatest([
+      this.route.queryParams.pipe(map(params => params['sfProjectId'])),
+      this.onlineStatusService.onlineStatus$,
+      this.dateRange$.pipe(filter(notNull))
+    ])


This does look like it was not the intention of this change to reload when switching tabs. Probably the distinctUntilChange pipe is the right choice here

marksvc

@marksvc made 4 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on RaymondLuong3).

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.html line 41 at r2 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Nit: This should be explicit currentProjectFilter != null

Thank you! Done.

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.html line 49 at r2 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

Thanks for the helpful label!

😄

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.spec.ts line 97 at r2 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

It looks like these projects can be added in a beforeEach for this describe.

Done.

marksvc · 2026-05-06T22:34:56Z

+    combineLatest([
+      this.route.queryParams.pipe(map(params => params['sfProjectId'])),
+      this.onlineStatusService.onlineStatus$,
+      this.dateRange$.pipe(filter(notNull))
+    ])


I think with the current implementation, it's not significant to use distinctUntilChanged, because if the user switches tabs, ServalBuildComponent I think is going to be destroyed, and another component is going to be shown. I suppose other URL parameters could get changed that the current page could start to use for something, like pagination. I have added distinctUntilChanged.

RaymondLuong3

@RaymondLuong3 reviewed 2 files and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on marksvc).

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-builds.component.spec.ts line 97 at r2 (raw file):

Previously, marksvc wrote…

Done.

I was actually thinking of using a beforeEach for the tests in this describe so that all tests in this describe initialize with the same projects. That is what i was asking for here.

serval-admin: serval-builds: add SF project ID filter

19111e7

This allows showing only Serval builds that correspond to a particular project. It can be tested by adding `&sfProjectId=FOO` to the URL.

marksvc requested a review from Copilot May 5, 2026 21:15

marksvc added e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete labels May 5, 2026

marksvc marked this pull request as draft May 5, 2026 21:15

Copilot started reviewing on behalf of marksvc May 5, 2026 21:15 View session

marksvc had a problem deploying to e2e_tests May 5, 2026 21:18 — with GitHub Actions Failure

marksvc temporarily deployed to e2e_tests May 5, 2026 21:18 — with GitHub Actions Inactive

Copilot AI reviewed May 5, 2026

View reviewed changes

marksvc added 2 commits May 5, 2026 15:37

Adjust

22371f7

Specify date to Avoid overlap error messages

d5c1bac

marksvc marked this pull request as ready for review May 5, 2026 21:38

marksvc had a problem deploying to e2e_tests May 5, 2026 21:41 — with GitHub Actions Failure

marksvc added testing not required and removed will require testing PR should not be merged until testers confirm testing is complete labels May 5, 2026

RaymondLuong3 requested changes May 5, 2026

View reviewed changes

RaymondLuong3 self-assigned this May 5, 2026

marksvc had a problem deploying to e2e_tests May 5, 2026 22:17 — with GitHub Actions Failure

marksvc had a problem deploying to e2e_tests May 6, 2026 21:34 — with GitHub Actions Failure

marksvc added 3 commits May 6, 2026 16:07

Not null

9dda8cb

distinctUntilChanged

c42744f

tests: make serval helper methods static

d92dd62

marksvc commented May 6, 2026

View reviewed changes

marksvc temporarily deployed to e2e_tests May 6, 2026 22:38 — with GitHub Actions Inactive

RaymondLuong3 requested changes May 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

serval-admin: serval-builds: add SF project ID filter#3846

serval-admin: serval-builds: add SF project ID filter#3846
marksvc wants to merge 6 commits intomasterfrom
task/sb-filter

marksvc commented May 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

RaymondLuong3 May 5, 2026

Uh oh!

marksvc May 6, 2026

Uh oh!

Uh oh!

codecov Bot commented May 5, 2026 •

edited

Loading

Uh oh!

RaymondLuong3 left a comment

Uh oh!

RaymondLuong3 May 5, 2026

Uh oh!

marksvc left a comment

Uh oh!

marksvc May 6, 2026

Uh oh!

RaymondLuong3 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

marksvc commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

RaymondLuong3 May 5, 2026

Choose a reason for hiding this comment

Uh oh!

marksvc May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

RaymondLuong3 left a comment

Choose a reason for hiding this comment

Uh oh!

RaymondLuong3 May 5, 2026

Choose a reason for hiding this comment

Uh oh!

marksvc left a comment

Choose a reason for hiding this comment

Uh oh!

marksvc May 6, 2026

Choose a reason for hiding this comment

Uh oh!

RaymondLuong3 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marksvc commented May 5, 2026 •

edited

Loading

codecov Bot commented May 5, 2026 •

edited

Loading