Skip to content

Update REVIEW.md instructions for localization update PRs#3842

Open
Nateowami wants to merge 1 commit intomasterfrom
agents/crowdin-review-instructions
Open

Update REVIEW.md instructions for localization update PRs#3842
Nateowami wants to merge 1 commit intomasterfrom
agents/crowdin-review-instructions

Conversation

@Nateowami
Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami commented May 4, 2026

Devin has been commenting on the "update from Crowdin" PRs saying the localization strings shouldn't be updated due to instructions in this file (before the instruction I think it was complaining about developers not updating them). This attempts to steer it away from that, while also telling it what we do care about (that variables and such match in the translations).


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.03%. Comparing base (b1f7a61) to head (7995dad).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3842   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files         630      630           
  Lines       40577    40577           
  Branches     6574     6555   -19     
=======================================
  Hits        32880    32880           
- Misses       6666     6679   +13     
+ Partials     1031     1018   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the agents/crowdin-review-instructions branch from ebfc89b to 7995dad Compare May 4, 2026 19:33
@Nateowami Nateowami changed the title Update REVIEW.md instructions for localizaation update PRs Update REVIEW.md instructions for localization update PRs May 4, 2026
@marksvc marksvc self-assigned this May 8, 2026
Copy link
Copy Markdown
Collaborator

@marksvc marksvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marksvc reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).


REVIEW.md line 22 at r1 (raw file):
What do you think about changing

to make sure the translators didn't mess them up.

to something like

to make sure they are correctly preserved.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants