Update REVIEW.md instructions for localization update PRs#3842
Open
Update REVIEW.md instructions for localization update PRs#3842
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3842 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 630 630
Lines 40577 40577
Branches 6574 6555 -19
=======================================
Hits 32880 32880
- Misses 6666 6679 +13
+ Partials 1031 1018 -13 ☔ View full report in Codecov by Sentry. |
ebfc89b to
7995dad
Compare
marksvc
requested changes
May 8, 2026
Collaborator
marksvc
left a comment
There was a problem hiding this comment.
@marksvc reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).
REVIEW.md line 22 at r1 (raw file):
What do you think about changing
to make sure the translators didn't mess them up.
to something like
to make sure they are correctly preserved.
?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devin has been commenting on the "update from Crowdin" PRs saying the localization strings shouldn't be updated due to instructions in this file (before the instruction I think it was complaining about developers not updating them). This attempts to steer it away from that, while also telling it what we do care about (that variables and such match in the translations).
This change is