Add missing error messages to onboarding form#3831
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3831 +/- ##
=======================================
Coverage 81.26% 81.26%
=======================================
Files 625 625
Lines 39638 39638
Branches 6443 6419 -24
=======================================
Hits 32213 32213
- Misses 6416 6429 +13
+ Partials 1009 996 -13 ☔ View full report in Codecov by Sentry. |
494667d to
663142e
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.html line 73 at r1 (raw file):
/> @if (signupForm.controls.translationLanguageName.hasError("required")) { <mat-error>{{ t("translation_language_name_required") }}</mat-error>
Is there a reason this needs to be specific. I would think it is better to just say "this field is required" since that translation is easy and shouldn't need to be updated.
Code quote:
<mat-error>{{ t("translation_language_name_required") }}</mat-error>663142e to
35fe654
Compare
Somehow I forgot to put error messages on two of the form fields.
Before
After
This change is