Skip to content

Add missing error messages to onboarding form#3831

Open
Nateowami wants to merge 1 commit intomasterfrom
feature/onboarding-form-error-messages
Open

Add missing error messages to onboarding form#3831
Nateowami wants to merge 1 commit intomasterfrom
feature/onboarding-form-error-messages

Conversation

@Nateowami
Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami commented Apr 24, 2026

Somehow I forgot to put error messages on two of the form fields.

Before

Screenshot from 2026-04-24 19-05-29

After

Screenshot from 2026-04-24 19-04-58
Open in Devin Review

This change is Reviewable

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.26%. Comparing base (9f24d06) to head (663142e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3831   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files         625      625           
  Lines       39638    39638           
  Branches     6443     6419   -24     
=======================================
  Hits        32213    32213           
- Misses       6416     6429   +13     
+ Partials     1009      996   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 force-pushed the feature/onboarding-form-error-messages branch from 494667d to 663142e Compare April 27, 2026 22:19
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).


src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.html line 73 at r1 (raw file):

                />
                @if (signupForm.controls.translationLanguageName.hasError("required")) {
                  <mat-error>{{ t("translation_language_name_required") }}</mat-error>

Is there a reason this needs to be specific. I would think it is better to just say "this field is required" since that translation is easy and shouldn't need to be updated.

Code quote:

<mat-error>{{ t("translation_language_name_required") }}</mat-error>

@RaymondLuong3 RaymondLuong3 self-assigned this Apr 27, 2026
@Nateowami Nateowami force-pushed the feature/onboarding-form-error-messages branch from 663142e to 35fe654 Compare April 28, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants