Skip to content

Add bash script demonstrating browser shell-wrapper pipe-hang bug (Brave + Chromium)#3748

Draft
Copilot wants to merge 9 commits intomasterfrom
copilot/fix-tests-hanging-at-end
Draft

Add bash script demonstrating browser shell-wrapper pipe-hang bug (Brave + Chromium)#3748
Copilot wants to merge 9 commits intomasterfrom
copilot/fix-tests-hanging-at-end

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

  • Reproduce current devcontainer build behavior and confirm failure point
  • Update /home/runner/work/web-xforge/web-xforge/.devcontainer/Dockerfile to omit NodeSource setup while keeping Node.js install and Brave install in-container
  • Rebuild devcontainer services (app, db) and verify container startup
  • Run timeout 180 npm run test:headless ... only inside the devcontainer
  • Share results and any remaining blockers
Original prompt

Frontend tests run but hang at the end. Even with --no-watch. Perhaps only in Ubuntu 24.04. When you try it out, I suggest you prefix the test run with timeout 180 so the test run is automatically killed when the timeout is succeeded.

Please reproduce the problem.
Please fix the problem so that the tests successfully finish and exit the process when completed (without needing to be killed by timeout).

To be clear, I want the following command to run and exit without hanging.

cd REPO_ROOT/src/SIL.XForge.Scripture/ClientApp && timeout 180 npm run test:headless -- --watch=false

Please do not assume that your edits or solutions have fixed the problem. You must verify that the problem is fixed by running the command.

The user has attached the following file paths as relevant context:

  • AGENTS.md

Created from VS Code.


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.


This change is Reviewable

Copilot AI changed the title [WIP] Fix frontend tests hanging issue on Ubuntu 24.04 Fix frontend test:headless hanging at end Mar 18, 2026
Copilot AI requested a review from marksvc March 18, 2026 21:08
Copilot AI changed the title Fix frontend test:headless hanging at end Fix frontend test:headless hanging at end; add devcontainer Mar 18, 2026
Copilot AI changed the title Fix frontend test:headless hanging at end; add devcontainer Add devcontainer with Brave browser for verifying frontend test fix Mar 19, 2026
Copilot AI changed the title Add devcontainer with Brave browser for verifying frontend test fix Install Brave browser in devcontainer and use it for frontend tests via CHROMIUM_BIN Mar 19, 2026
Copilot AI changed the title Install Brave browser in devcontainer and use it for frontend tests via CHROMIUM_BIN Fix karma test run hanging at end when using Brave browser Mar 19, 2026
Copilot AI changed the title Fix karma test run hanging at end when using Brave browser Add bash script demonstrating browser shell-wrapper pipe-hang bug (Brave + Chromium) Mar 19, 2026
@marksvc
Copy link
Copy Markdown
Collaborator

marksvc commented Mar 24, 2026

I preserved the results locally.

@marksvc marksvc closed this Mar 24, 2026
@marksvc marksvc deleted the copilot/fix-tests-hanging-at-end branch March 24, 2026 22:17
@marksvc marksvc restored the copilot/fix-tests-hanging-at-end branch May 1, 2026 18:12
@marksvc marksvc reopened this May 1, 2026
Copilot stopped work on behalf of marksvc due to an error May 1, 2026 18:51
Fix frontend tests hanging by adding --watch=false to test:headless script

Add devcontainer and verify the test:headless fix inside it

Update devcontainer to install and use Brave browser for frontend
tests

Co-authored-by: marksvc <7265309+marksvc@users.noreply.github.com>

Install Brave browser in devcontainer and use it for frontend tests
via CHROMIUM_BIN

Co-authored-by: marksvc <7265309+marksvc@users.noreply.github.com>

Fix karma hang: point CHROMIUM_BIN at brave binary directly, not the
shell wrapper

Co-authored-by: marksvc <7265309+marksvc@users.noreply.github.com>

Add bash script demonstrating the Brave pipe-hang bug

Co-authored-by: marksvc <7265309+marksvc@users.noreply.github.com>

Extend pipe-hang test to also test Chromium browser (Debian wrapper
and direct binary)

Co-authored-by: marksvc <7265309+marksvc@users.noreply.github.com>

chore(clientapp): update angular packages to patched versions

Agent-Logs-Url:
https://github.com/sillsdev/web-xforge/sessions/92599b64-061a-43ba-9a38-46f8ba43c085

Co-authored-by: marksvc <7265309+marksvc@users.noreply.github.com>

rename devcontainer dir
@marksvc marksvc force-pushed the copilot/fix-tests-hanging-at-end branch from 4a34905 to 2878158 Compare May 1, 2026 20:45
Copilot finished work on behalf of marksvc May 1, 2026 20:49
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.02%. Comparing base (9f464e2) to head (2878158).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3748   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files         630      630           
  Lines       40632    40632           
  Branches     6603     6598    -5     
=======================================
  Hits        32922    32922           
  Misses       6676     6676           
  Partials     1034     1034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copilot AI and others added 8 commits May 1, 2026 21:21
Agent-Logs-Url: https://github.com/sillsdev/web-xforge/sessions/e83ebc75-61ab-46b9-ae7e-5b975eed9049

Co-authored-by: marksvc <7265309+marksvc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants