SF-3686 Enable SignalR reconnecting with statefulness#3655
SF-3686 Enable SignalR reconnecting with statefulness#3655RaymondLuong3 merged 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3655 +/- ##
==========================================
- Coverage 81.91% 81.90% -0.01%
==========================================
Files 618 618
Lines 38542 38551 +9
Branches 6285 6309 +24
==========================================
+ Hits 31570 31574 +4
+ Misses 6012 6004 -8
- Partials 960 973 +13 ☔ View full report in Codecov by Sentry. |
70eb3c6 to
b66ba31
Compare
b66ba31 to
4a3f116
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
RaymondLuong3
left a comment
There was a problem hiding this comment.
Let's get this to QA and see if it makes a difference. I have seen drafts on QA that complete but a page refresh is needed to see the new draft.
@RaymondLuong3 made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
This PR helps the SignalR server and client to reconnect and resend any missed messages if the connection is interrupted for some reason, such as connectivity issues.
I have also cherrypicked a commit from #3638 that will unsubscribed from notifications, to ensure that the server does not remember messages for clients that no longer require SignalR notifications for a sync or draft.
This change is