Skip to content

Improve logging when Hangfire operation canceled #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enkidu93 merged 1 commit into from
Feb 17, 2026
Merged

Improve logging when Hangfire operation canceled #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Machine/src/Serval.Machine.Shared/Services/HangfireBuildJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,11 @@ CancellationToken cancellationToken

await DoWorkAsync(engineId, buildId, data, buildOptions, cancellationToken);
}
catch (OperationCanceledException)
catch (OperationCanceledException e)
{
// Log the full exception for debugging purposes
Logger.LogInformation(e, "Build Hangfire job canceled ({0})", buildId);

// Check if the cancellation was initiated by an API call or a shutdown.
TEngine? engine = await Engines.GetAsync(
e => e.EngineId == engineId && e.CurrentBuild != null && e.CurrentBuild.BuildId == buildId,
Expand Down Expand Up @@ -93,10 +96,12 @@ await DataAccessContext.WithTransactionAsync(
},
cancellationToken: CancellationToken.None
);
Logger.LogInformation("Build restarting ({0})", buildId);
throw;
}
else
{
Logger.LogInformation("Build engine not found ({0})", buildId);
completionStatus = JobCompletionStatus.Canceled;
}
}
Expand Down
Loading