Conversation
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @papeh).
src/Overcrowdin/Overcrowdin.csproj line 54 at r1 (raw file):
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" /> <PackageReference Include="System.IO.Abstractions" Version="22.1.0" /> <PackageReference Include="System.Text.Json" Version="10.0.2" /> <!--the automatically included version includes a vulnerability; specify a version for now -->
❓ Is this comment still relevant? And aren't we always explicitly including a version anyway.
papeh
left a comment
There was a problem hiding this comment.
@papeh made 1 comment.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec).
src/Overcrowdin/Overcrowdin.csproj line 54 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
❓ Is this comment still relevant? And aren't we always explicitly including a version anyway.
Good catch. The version included as a transitive dependency is no longer subject to the vulnerability, so I've removed this line.
This change is