Skip to content

Update Dependencies#68

Merged
papeh merged 2 commits intomasterfrom
update/deps
Feb 9, 2026
Merged

Update Dependencies#68
papeh merged 2 commits intomasterfrom
update/deps

Conversation

@papeh
Copy link
Copy Markdown
Contributor

@papeh papeh commented Feb 6, 2026

This change is Reviewable

Copy link
Copy Markdown

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @papeh).


src/Overcrowdin/Overcrowdin.csproj line 54 at r1 (raw file):

    <PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
    <PackageReference Include="System.IO.Abstractions" Version="22.1.0" />
    <PackageReference Include="System.Text.Json" Version="10.0.2" /> <!--the automatically included version includes a vulnerability; specify a version for now -->

❓ Is this comment still relevant? And aren't we always explicitly including a version anyway.

Copy link
Copy Markdown
Contributor Author

@papeh papeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@papeh made 1 comment.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec).


src/Overcrowdin/Overcrowdin.csproj line 54 at r1 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

❓ Is this comment still relevant? And aren't we always explicitly including a version anyway.

Good catch. The version included as a transitive dependency is no longer subject to the vulnerability, so I've removed this line.

@papeh papeh merged commit 0834d8b into master Feb 9, 2026
3 of 4 checks passed
@papeh papeh deleted the update/deps branch February 9, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants