Skip to content

Add core: scripts to package.json#2184

Open
imnasnainaec wants to merge 1 commit intodevelopfrom
pb-ext-package-scripts-core
Open

Add core: scripts to package.json#2184
imnasnainaec wants to merge 1 commit intodevelopfrom
pb-ext-package-scripts-core

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec self-assigned this Feb 27, 2026
@imnasnainaec imnasnainaec added the 🟩Low Low-priority PR label Feb 27, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef61e00 and 5cd00d9.

📒 Files selected for processing (1)
  • platform.bible-extension/package.json

📝 Walkthrough

Walkthrough

Refactored npm scripts in package.json to eliminate direct directory navigation to paranext-core. Removed start:core and stop scripts; introduced new core:* scripts (start, stop, install, pull, update) using npm --prefix for delegated execution. Updated start and start:production to call npm:core:start.

Changes

Cohort / File(s) Summary
Script Refactoring
platform.bible-extension/package.json
Removed start:core and stop scripts. Added five new core:* scripts (core:start, core:stop, core:install, core:pull, core:update) that use npm --prefix ../../paranext-core or git operations to manage paranext-core. Updated start and start:production to invoke npm:core:start instead of npm:start:core. Minor formatting adjustment to lint-fix:scripts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Scripts now hop with grace,
No more dir commands to chase,
With --prefix spells we weave,
Core control we now retrieve,
Simpler paths through garden's place.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding new 'core:' scripts to package.json with new public script entries and updating start scripts.
Description check ✅ Passed The description references a related pull request that the changes mirror, which relates to the changeset's purpose of adding core scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pb-ext-package-scripts-core

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant