Skip to content

Add The Combine to Seeding Data#2180

Open
imnasnainaec wants to merge 3 commits intodevelopfrom
seeding-data-for-the-combine
Open

Add The Combine to Seeding Data#2180
imnasnainaec wants to merge 3 commits intodevelopfrom
seeding-data-for-the-combine

Conversation

@imnasnainaec
Copy link
Collaborator

No description provided.

@imnasnainaec imnasnainaec self-assigned this Feb 23, 2026
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Feb 23, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

📝 Walkthrough

Walkthrough

A new OpenIddictApplicationDescriptor entry is added to the OAuthApps seed data in SeedingData.cs, configuring a public native client named "the-combine" with ClientId "the-combine", explicit consent, specific OAuth permissions, and five redirect URIs targeting development, Docker, Rancher, QA, and production environments.

Changes

Cohort / File(s) Summary
OAuth Seed Data
backend/LexData/SeedingData.cs
Adds OpenIddictApplicationDescriptor for "the-combine" public native client with explicit consent, permissions (Authorization, Token, Code, Email, Profile, and SendAndReceive scope), and five redirect URIs across dev, Docker, Rancher, QA, and production environments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A carrot-sized app takes the stage,
"The Combine" claims its OAuth page,
Five paths to home, from Docker's care,
To production's dance in the open air!
Explicit consent, permissions set bright—
Seeds are sown for a seamless flight! 🌾✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a description explaining the purpose of adding The Combine OAuth application, its use case, and any relevant context about the redirect URIs and permissions.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding The Combine to seeding data in the OAuth configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch seeding-data-for-the-combine

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the 📦 Lexbox issues related to any server side code, fw-headless included label Feb 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

C# Unit Tests

162 tests  +2   162 ✅ +2   19s ⏱️ -1s
 23 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 06c897f. ± Comparison against base commit d3a5b3e.

♻️ This comment has been updated with latest results.

@imnasnainaec imnasnainaec changed the title Add The Combine to DevApps Add The Combine to Seeding Data Feb 27, 2026
@imnasnainaec imnasnainaec marked this pull request as ready for review February 27, 2026 18:44
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
backend/LexData/SeedingData.cs (1)

330-336: Consider extracting callback path and URI list constants for maintainability.

The repeated /v1/auth/oauth-callback suffix across multiple URIs is easy to drift over time. A small constant-based extraction would reduce typo risk in future edits.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@backend/LexData/SeedingData.cs` around lines 330 - 336, The repeated
"/v1/auth/oauth-callback" literal in the RedirectUris initializer in
SeedingData.cs should be extracted into a named constant (e.g., CallbackPath)
and the host/base URIs collected into a single list/array constant (e.g.,
OAuthCallbackHosts or CallbackBaseUris) so RedirectUris is constructed by
combining each base with CallbackPath; update the code that sets RedirectUris
(the initializer where RedirectUris = { new Uri(... ) }) to use the constants
(or string interpolation/Uri base+path) to avoid duplication and reduce drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@backend/LexData/SeedingData.cs`:
- Around line 330-336: The repeated "/v1/auth/oauth-callback" literal in the
RedirectUris initializer in SeedingData.cs should be extracted into a named
constant (e.g., CallbackPath) and the host/base URIs collected into a single
list/array constant (e.g., OAuthCallbackHosts or CallbackBaseUris) so
RedirectUris is constructed by combining each base with CallbackPath; update the
code that sets RedirectUris (the initializer where RedirectUris = { new Uri(...
) }) to use the constants (or string interpolation/Uri base+path) to avoid
duplication and reduce drift.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3a5b3e and 06c897f.

📒 Files selected for processing (1)
  • backend/LexData/SeedingData.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 Lexbox issues related to any server side code, fw-headless included 🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants